Repository navigation
Fix Forge installation in shared skill discovery directories - #1
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amplifier scans both
~/.agents/skillsand~/.amplifier/skills. Forge's installer linked the shared.agentsentry to a checkout outside the discovery boundary, so every startup/resume warned about the rejected link even though the Amplifier-specific copy was valid.Install refreshable real copies in both scanned locations, migrating existing symlinks without touching their targets. Keep the Claude/OpenCode and optional legacy Codex links. Exclude development caches and virtual environments from copied payloads, and document that checkout updates require rerunning the installer.
Validation: 34 unit/contract tests pass on macOS, including new isolated-home tests for fresh installation, migration, repeated refreshes and stale-file removal, dry runs, and the tar fallback without rsync.
bash -n scripts/install.shandgit diff --checkpass. Runtime tools and skill instructions are unchanged.