[aniket866]

Describe the bug

Description

refreshAuthToken in pkg/connectors/microcks_client.go calls
jwt.ParseUnverified(configCtx.User.AuthToken, &claims) without first checking
whether AuthToken is empty. After a fresh install, after logout --token-only,
or whenever the config exists but contains no token, AuthToken is "". The JWT
parser returns an error for the empty string, which propagates all the way up to
NewClient and then to the user as a low-level JWT error rather than a
human-readable "please run microcks login" message.

// microcks_client.go (refreshAuthToken)
if c.RefreshToken == "" {
    return nil  // ← correctly handles empty refresh token
}
// ... but AuthToken="" is never guarded:
_, _, err = parser.ParseUnverified(configCtx.User.AuthToken, &claims)
if err != nil {
    return err  // ← surfaces as "token is malformed: ..." to the user
}

Ai Disclosure: No ai is used to code these lines,

Closes #551

[naitk2]

check code if err != nil {
return err // ← surfaces as "token is malformed: ..." to the user

[Vaishnav88sk]

LGTM 👍🏻

[yada]

Verified the merge result (build, go vet, go test ./... pass). With a context holding a refresh token but an empty access token, service list fails on master with token contains an invalid number of segments (exit 20). With this PR it says not authenticated. Run microcks login first (exit 2).

Disclosure: this comment was drafted with AI assistance, and the results were run locally.

[yada]

Verified locally. Disclosure: AI-assisted verification.