Repository navigation
fix: import primary artifacts before secondary artifacts - #562
Conversation
Signed-off-by: Lalit Kishore <[email protected]>
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
Signed-off-by: Lalit Kishore <[email protected]>
|
Verified the merge result (build, Disclosure: this comment was drafted with AI assistance, and the results were run locally. |
yada
left a comment
yada
left a comment
There was a problem hiding this comment.
Verified locally. Disclosure: AI-assisted verification.
|
You are now a Microcks community contributor! 💖 Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏 📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌" Kudos and please keep going, we need you 🙌 |
Fixes #561.
import-dircurrently uploadsexamples.yamlbeforeopenapi.yamlbecause it follows filesystem discovery order. On a first import, a secondary artifact can arrive before its API exists and be ignored. This change uploads detected primary artifacts first, preserving discovery order within each group.Regression tests cover flat and recursive directories, stable ordering, primary-only and secondary-only imports, filtering, and upload-failure accounting. Four cases fail before the fix; all six pass after it. Tests use the real filesystem and a recording upload client; no live Microcks server was used.
Validation:
go test ./...go test -race ./cmd -run 'TestImportDirectory' -count=1go build ./...go vet ./...git diff --checkAI disclosure: ChatGPT was used to help implement the fix, write regression tests, and review and double-check the changes.