Repository navigation
fix: honor --config flag in login command (#594) - #599
Open
aryarathoree wants to merge 1 commit into
Open
aryarathoree wants to merge 1 commit into
aryarathoree wants to merge 1 commit into
Conversation
The login command bypassed the global --config flag and hardcoded a call to config.DefaultLocalConfigPath(), causing credentials and contexts to always be written to the default ~/.config/microcks/config. Update cmd/login.go to use globalClientOpts.ConfigPath, falling back to DefaultLocalConfigPath if unset. Add unit tests verifying custom config paths are respected and preserved. Signed-off-by: Arya Rathore <[email protected]>
aryarathoree
requested review from
Caesarsage,
Harsh4902,
lbroudoux and
yada
as code owners
October 27, 2026 19:55
|
Welcome to the Microcks community! 💖 Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly. Hope you have a great time there! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
microcks login, the global--configflag is ignored. Incmd/login.go, the code hardcoded a call toconfig.DefaultLocalConfigPath()instead of usingglobalClientOpts.ConfigPath, causing login credentials and contexts to always be read from and written to~/.config/microcks/config.Solution
cmd/login.goto useglobalClientOpts.ConfigPath, falling back toconfig.DefaultLocalConfigPath()only when unset.cmd/login_test.goverifying:--configcreates and populates the specified custom configuration file.--nameare preserved in the custom config.Fixes #594