Repository navigation
Refresh diagnostics when a content-mapped or declaration file changes on disk - #64944
Open
Lubos (mrlubos) wants to merge 1 commit into
Open
Lubos (mrlubos) wants to merge 1 commit into
Lubos (mrlubos) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses both extension-filtering failures, preserves directory handling, and includes targeted regression coverage.
No open issues 🎉
What changed in this PR
Fixes #64943 by ensuring disk changes to content-mapped and declaration files trigger diagnostics refreshes in the language server.
Changes:
- Checks content-mapper extensions before TypeScript-specific extension detection.
- Treats recognized declaration extensions as relevant to diagnostics.
- Adds regression tests for both refresh scenarios.
| File | Description |
|---|---|
tsc/internal/project/session.go |
Corrects watched-file filtering for mapped and declaration files. |
tsc/internal/project/session_test.go |
Tests diagnostics refresh after a declaration file changes on disk. |
tsc/internal/project/contentmapper_test.go |
Tests diagnostics refresh after a content-mapped file changes on disk. |
Review effort: Balanced
… on disk microsoft#64159 changed DidChangeWatchedFiles to read the extension through path.Extension(), which knows only TypeScript's own extensions. A content-mapped file such as shape.data got "" and was treated as a possible directory, so the content mapper extension check was never reached. A .d.ts file got ".d.ts", which isRelevantExtension does not list. Neither change scheduled a diagnostics refresh. Fixes microsoft#64943
Lubos (mrlubos)
force-pushed
the
fix/content-mapper-watch-refresh
branch
from
October 23, 2026 20:59
62451b9 to
f8edd05
Compare
Author
|
@microsoft-github-policy-service agree company="Hey API" |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64159 changed
DidChangeWatchedFilesto read the extension throughpath.Extension(), which knows only TypeScript's own extensions. A content-mapped file such asshape.datagot""and was treated as a possible directory, so the content mapper extension check was never reached. A.d.tsfile got".d.ts", whichisRelevantExtensiondoes not list. Neither change scheduled a diagnostics refresh.Fixes #64943