Repository navigation
fix: isolate SDL npm registry from build CFS configuration - #1789
Merged
Merged
Conversation
wenyt (wenytang-ms)
requested review from
Changyong Gong (chagong),
Sheng Chen (jdneo) and
Jinbo Wang (testforstephen)
as code owners
October 30, 2026 05:35
Changyong Gong (chagong)
left a comment
Contributor
There was a problem hiding this comment.
No blocking issue found in the YAML diff: the registry reset is SDL-only, with Build CFS routing, Node versions, pools, permissions and release YAMLs unchanged. The Azure SDL and CFS dependency-validation checks pass.
Withholding approval for now because three macOS E2E jobs remain red:
- java-gradle-java25: the report shows missing Java 25 compiler preferences and a Buildship project nature instead of the expected Gradle build-server nature.
- java-gradle-java27: the expected compiler.source=27 entry is absent from the JDT preferences file.
- java27-primitive-patterns: output verification for REOPEN_INSERTION_CONFIRMED reports an error.
These failures occur in GitHub Actions, outside the modified Azure SDL configuration, and appear unrelated to this change. However, today's main-branch baseline has different failures, not these same three, so I cannot confidently label them established baseline failures. Please triage/rerun these jobs or provide evidence that they are pre-existing before approval.
Changyong Gong (chagong)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
npm_config_registrytoextends.parameters.sdl.sourceAnalysisVariablesToResetin CI, Nightly and RC. This isolates SDL/Guardian from the Build-only global CFS registry.Preserve global Build CFS routing, all existing sourceAnalysisPool/pool settings, SpotBugs and network-isolation settings where present, Node versions and permissions. Release YAMLs are unchanged.
Validation
mainate9526f180260a4f9ed682c34953af35c66ca6937.previewRun:true+yamlOverridecompilations succeeded for every enabled source definition: 16482, 16483, 23369, with self fixed to that SHA.npm_config_registry: ''inSDLSources_self; all other compiled content is identical.git diff --checkpassed.Scope and limitations
This is the same narrow isolation used in microsoft/vscode-spring-boot-dashboard#453.
Preview compiles but does not execute Guardian/feed authentication. No repository-specific npm6/E401 reproduction or post-fix runtime success is claimed. No build or release was manually queued.