Repository navigation
fix(argocd-pr-env-deploy): turn the staff console off when no Deploys line selects it (ENG-3872) - #75
Merged
Conversation
… line selects it (ENG-3872)
…olved Deploys links (ENG-3872)
mindsdb-devops
approved these changes
Nov 1, 2026
mindsdb-devops
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As an engineer, I want removing a
Deploys: mindshub_stafftools#...line to turn the staff console off in my PR env, so that the console runs only while a PR selects it.Why this matters
argocd app setonly adds parameters. Removing the line left the console running until someone unset its parameters by hand.What should happen
When the deploy sets no stafftools revision, the deploy step unsets
tags.mindshub_stafftoolsandrevisions.mindshub_stafftoolson the parent. A mindshub_stafftools anchor or aDeploys: mindshub_stafftools#...line sets that revision, so the step reads the links the deploy already resolved rather than parsing the body a second time. It keeps every other parameter, and it does nothing when neither is set.Test plan
Deploys:link loop with GitHub stubbed, run against a fakeargocd, unsets exactly those two parameters. Passed under bash 5.2, as on the runner.Deploys:form (#N,#staging,#main, with or without the org), resolved by the action's own link loop, skip the unset. Other repos' links and look-alike names don't select it. Passed.app set, and not before the parent exists. Passed.