Repository navigation
Keep following a relative redirect when the endpoint URL carries userinfo #3450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -208,6 +208,20 @@ async def test_redirect_location_with_userinfo_is_not_followed(): | |
| assert received == [f"POST {url}"] | ||
|
|
||
|
|
||
| async def test_userinfo_of_the_configured_url_kept_by_a_relative_location_is_followed(): | ||
| """Userinfo the caller put in the endpoint URL is carried over by a relative Location (URL join | ||
| keeps the authority); that is the caller's own credential for the same origin, so the redirect | ||
| is followed as httpx2 itself would (SDK-defined).""" | ||
| url = "http://user:[email protected]/mcp" | ||
| client, received, _ = _recording_client({url: (307, "/mcp/")}) | ||
|
|
||
| async with client, stream_within_origin(client, "POST", url, content=b"payload") as response: | ||
| await response.aread() | ||
|
|
||
| assert response.status_code == 200 | ||
| assert received == [f"POST {url}", "POST http://user:[email protected]/mcp/"] | ||
|
|
||
|
|
||
| async def test_request_within_origin_returns_a_read_response(): | ||
| """The non-streaming form hands back a response whose body is already read.""" | ||
| url = "http://mcp.example/mcp" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.