Repository navigation
Report failed session notifications through the server configuration - #631
Open
koic wants to merge 1 commit into
Conversation
## Motivation and Context `ServerSession#notify_progress`, `#notify_log_message`, `#notify_resources_updated` and `#notify_elicitation_complete` rescue a transport failure and pass it to `@server.report_exception`, which is private, so the rescue itself raised `NoMethodError`. The failure meant to be reported and swallowed reached the caller instead, typically a tool reporting progress or logging, whose call then answered Internal error. The rescues now call `exception_reporter` of the server's configuration, which is what `Server#report_exception` does, without making that method public. ## How Has This Been Tested? `test/mcp/server_notification_test.rb`. Against the previous library the new test fails with `NoMethodError: private method 'report_exception' called for an instance of MCP::Server`. ## Breaking Changes None.
atesgoral
approved these changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ServerSession#notify_progress,#notify_log_message,#notify_resources_updatedand#notify_elicitation_completerescue a transport failure and pass it to@server.report_exception, which is private, so the rescue itself raisedNoMethodError. The failure meant to be reported and swallowed reached the caller instead, typically a tool reporting progress or logging, whose call then answered Internal error.The rescues now call
exception_reporterof the server's configuration, which is whatServer#report_exceptiondoes, without making that method public.How Has This Been Tested?
test/mcp/server_notification_test.rb. Against the previous library the new test fails withNoMethodError: private method 'report_exception' called for an instance of MCP::Server.Breaking Changes
None.
Types of changes
Checklist