Repository navigation
Conversation
…d retryable writes unified tests for retryable handshake errors
4 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
These focused, test-only changes consistently match client application names to failpoint filters, with no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR reduces flakiness in PyMongo’s unified handshake-error and command-logging tests by limiting failpoints to the intended test clients.
Changes:
- Adds explicit application names to clients in all three fixtures.
- Adds matching application-name filters to failpoints so unrelated clients do not consume the injected failures.
| File | Description |
|---|---|
test/retryable_writes/unified/handshakeError.json |
Scopes handshake failpoints to the retryable-write test client. |
test/retryable_reads/unified/handshakeError.json |
Scopes handshake failpoints to the retryable-read test client. |
test/command_logging/redacted-commands.json |
Scopes authentication failpoints to the command-redaction test client. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-6122. Implements mongodb/specifications#1988.
Changes in this PR
See ticket.
Test Plan
Unified test changes.
Checklist
Checklist for Author
Checklist for Reviewer