Skip to content

PYTHON-6122 Address flakiness in command logging, retryable reads, and retryable writes unified tests for retryable handshake errors - #3064

Open
NoahStapp wants to merge 5 commits into
mongodb:mainfrom
NoahStapp:PYTHON-6122
Open

NoahStapp wants to merge 5 commits into
mongodb:mainfrom
NoahStapp:PYTHON-6122

Conversation

@NoahStapp

@NoahStapp NoahStapp commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

PYTHON-6122. Implements mongodb/specifications#1988.

Changes in this PR

See ticket.

Test Plan

Unified test changes.

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

…d retryable writes unified tests for retryable handshake errors
@NoahStapp NoahStapp changed the title PYTHON-6122 Address flakiness in command logging, retryable reads, an… PYTHON-6122 Address flakiness in command logging, retryable reads, and retryable writes unified tests for retryable handshake errors Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@NoahStapp
NoahStapp marked this pull request as ready for review October 23, 2026 15:14
@NoahStapp
NoahStapp requested a review from a team as a code owner October 23, 2026 15:14
@NoahStapp
NoahStapp requested review from blink1073 and a balanced review from Copilot October 23, 2026 15:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

These focused, test-only changes consistently match client application names to failpoint filters, with no identified blocking issues.

No open issues 🎉

What changed in this PR

This PR reduces flakiness in PyMongo’s unified handshake-error and command-logging tests by limiting failpoints to the intended test clients.

Changes:

  • Adds explicit application names to clients in all three fixtures.
  • Adds matching application-name filters to failpoints so unrelated clients do not consume the injected failures.
File Description
test/​retryable_writes/​unified/​handshakeError.json Scopes handshake failpoints to the retryable-write test client.
test/​retryable_reads/​unified/​handshakeError.json Scopes handshake failpoints to the retryable-read test client.
test/​command_logging/​redacted-commands.json Scopes authentication failpoints to the command-redaction test client.

Review effort: Balanced

@blink1073 blink1073 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants