Repository navigation
fix(build): clean up system_lua option - #239
Open
robbielyman wants to merge 2 commits into
Open
robbielyman wants to merge 2 commits into
robbielyman wants to merge 2 commits into
Conversation
Collaborator
Author
|
Since this change is hard to test with CI, here is how I tested it: I have Lua 5.5 installed via homebrew at zig build test -fsys=system_lua --search-prefix /opt/homebrew -Dadditional_system_headers=/opt/homebrew/include/luaThis change therefore does not remove |
robbielyman
force-pushed
the
push-sovkyvnkmwuq
branch
from
October 31, 2026 01:50
2fb117e to
6c4c76f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This change removes `-Dsystem_lua` in favor of `-fsys=system_lua`. In
order to find Lua, the user should pass `--search-prefix {dir}`, where Lua
is installed in `{dir}/lib`. In the happy case that `lua.h` is present as
`{dir}/include/lua.h`, no further action is needed. Otherwise (for example if
`lua.h` is `{dir}/include/lua/lua.h`), the user should pass the path to the
directory containing `lua.h` as an argument to `-Dadditional_system_headers`.
If `-fsys=system_lua` is present, the default for `-Dshared` is now `true`.
Also, rather than panicking the configure stage, I added `addFail` steps.
robbielyman
force-pushed
the
push-sovkyvnkmwuq
branch
from
October 31, 2026 01:52
6c4c76f to
2a184fd
Compare
robbielyman
force-pushed
the
push-sovkyvnkmwuq
branch
from
October 31, 2026 01:53
2a184fd to
23834a8
Compare
Owner
|
Just tested this on Linux and it works well! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes
-Dsystem_luain favor of-fsys=system_lua. In order to find Lua, the user should pass--search-prefix {dir}, where Lua is installed in{dir}/lib. In the happy case thatlua.his present as{dir}/include/lua.h, no further action is needed. Otherwise (for example iflua.his{dir}/include/lua/lua.h), the user should pass the path to the directory containinglua.has an argument to-Dadditional_system_headers.If
-fsys=system_luais present, the default for-Dsharedis nowtrue. Also, rather than panicking the configure stage, I addedaddFailsteps.