Repository navigation
Conversation
vkalintiris
reviewed
Oct 29, 2026
Comment on lines
+1075
to
+1077
| retention: | ||
| default: | ||
| max_total_size: 10GB |
There was a problem hiding this comment.
Should be something like this because logs/traces haves separate retention configuration values:
endpoint:
path: {{ printf "\"0.0.0.0:%v\"" .Values.netdataOpentelemetry.service.port }}
logs:
retention:
default:
max_total_size: "5GB"
traces:
retention:
default:
max_total_size: "5GB"
I'd expect us to have more users trying to use this for logs, rather than traces. I would change the default allocation to 9GB for logs and 1GB for traces, but I'll leave this up to you.
mtblz
force-pushed
the
otel-config-update
branch
2 times, most recently
from
October 29, 2026 14:52
c9551a9 to
30c3968
Compare
vkalintiris
reviewed
Oct 29, 2026
| duration_of_journal_files: "7 days" | ||
| duration_of_journal_file: "2 hours" | ||
| store_otlp_json: false | ||
| retention: |
There was a problem hiding this comment.
The path is logs.retention.default.max_total_size, ie. not retention.default.max_total_size.
mtblz
force-pushed
the
otel-config-update
branch
from
October 29, 2026 14:55
30c3968 to
46e4c07
Compare
vkalintiris
approved these changes
Oct 29, 2026
witalisoft
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the configuration of the OTEL plugin to the newer format.