Skip to content

refactor(get-public-key): rename to get certificate - #17860

Merged
alperozturk96 merged 3 commits into
masterfrom
remove-confusion-for-e2ee-operations
Oct 29, 2026
Merged

alperozturk96 merged 3 commits into
masterfrom
remove-confusion-for-e2ee-operations

Conversation

@alperozturk96

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt 0.00% 1 Missing ⚠️
...oid/operations/CreateShareWithShareeOperation.java 0.00% 1 Missing ⚠️
...g/setupEncryption/SetupEncryptionDialogFragment.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 25efb01
Version 17860
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

daniele-verducci

This comment was marked as resolved.

@alperozturk96
alperozturk96 force-pushed the remove-confusion-for-e2ee-operations branch from 8286059 to fcec99f Compare October 27, 2026 15:25
@alperozturk96

This comment was marked as resolved.

@alperozturk96
alperozturk96 dismissed daniele-verducci’s stale review October 27, 2026 15:29

i thinks its related to the server 429 errors. local instance can have this.

@daniele-verducci

This comment was marked as resolved.

@daniele-verducci daniele-verducci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

Signed-off-by: alperozturk96 <[email protected]>

# Conflicts:
#	gradle/libs.versions.toml
Signed-off-by: alperozturk96 <[email protected]>

# Conflicts:
#	gradle/libs.versions.toml
Signed-off-by: alperozturk96 <[email protected]>
@alperozturk96
alperozturk96 force-pushed the remove-confusion-for-e2ee-operations branch from fcd9146 to 25efb01 Compare October 29, 2026 14:08
@alperozturk96
alperozturk96 merged commit cc16cd5 into master Oct 29, 2026
22 of 23 checks passed
@alperozturk96
alperozturk96 deleted the remove-confusion-for-e2ee-operations branch October 29, 2026 14:18
@github-actions

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4545
Dodgy code146146
Experimental11
Malicious code vulnerability11
Multithreaded correctness1818
Performance2828
Security1515
Total278278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants