Repository navigation
fix(settings): replace Moment with localized date and time composables - #66029
Open
joshtrichards wants to merge 4 commits into
Open
joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
Moments uses the locale instead of the language for localization. Replace Moment formatting in BackgroundJob with Nextcloud Vue's useFormatRelativeTime composable. Fixes #45069 Fixes nextcloud-libraries/nextcloud-moment#1061 Signed-off-by: Josh <[email protected]>
joshtrichards
requested review from
kristian-zendato,
pringelmann and
skjnldsv
and removed request for
a team
October 30, 2026 01:57
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
joshtrichards
added
bug
papercut
Replace Moment with useFormatTime to format the example using the current user's locale. Use useNow to preserve one-second updates and automatically clean up the timer on unmount. Closes #45069 Assisted-by: Copilot:gpt-6.1-sol Signed-off-by: Josh <[email protected]>
joshtrichards
changed the title
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Momentuses the locale instead of the language for localization. ReplaceMomentformatting in background job status and the personal locale example with Nextcloud Vue composables:useFormatRelativeTimefor background jobs so relative text follows the user’s language rather than their locale.useFormatTimefor the locale example anduseNowto preserve one-second updates with automatic timer cleanup.Context: https://github.com/nextcloud-libraries/nextcloud-vue/pull/7067/changes
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)