Skip to content

fix(ncu-ci): exclude nodejs-private from reports - #1227

Merged
panva merged 1 commit into
nodejs:mainfrom
panva:exclude-nodejs-private
Oct 25, 2026
Merged

panva merged 1 commit into
nodejs:mainfrom
panva:exclude-nodejs-private

Conversation

@panva

@panva panva commented Oct 25, 2026

Copy link
Copy Markdown
Member

Filter private builds before counting results and selecting failures.

Filter private builds before counting results and selecting failures.
Handle reports with no remaining failures.

Signed-off-by: Filip Skokan <[email protected]>
Assisted-by: Codex
@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.86%. Comparing base (ade9a85) to head (1deba2b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
+ Coverage   64.58%   64.86%   +0.28%     
==========================================
  Files          65       65              
  Lines       12328    12334       +6     
==========================================
+ Hits         7962     8001      +39     
+ Misses       4366     4333      -33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva
panva merged commit 31ac767 into nodejs:main Oct 25, 2026
11 checks passed
@panva
panva deleted the exclude-nodejs-private branch October 25, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants