[junyup0503]

Since #64987, chunked writes made while the response is auto-corked are coalesced, and write() returns false based on the byte length of the buffered chunks. When uncork() flushes them, net.Socket counts string chunks in UTF-16 code units, so with multi-byte text the socket can stay below its own highWaterMark and never emits 'drain'. If the flushed writes complete asynchronously, the check at the end of uncork() also runs while bytes are still pending, so the response stalls with writableNeedDrain === true and writableLength === 0.

This re-checks the drain condition in the write callback of the flushed data, unless the message or its socket has been destroyed. It does not change the accounting itself (e.g. encoding the coalesced strings to Buffers), to avoid adding cost to the write path that #64987 optimized.

The new test uses a Duplex that counts strings like net.Socket and completes writes asynchronously, so it does not depend on OS socket buffer sizes. It hangs on main without the change and passes with it. It also checks that 'drain' is not emitted after the response is destroyed from a write callback. parallel/test-http*, parallel/test-stream*, parallel/test-net*, sequential/test-http* and make lint-js pass locally.

Fixes: #66781
Refs: #64987

I used an AI coding agent to help investigate and write this change. I reproduced the issue and verified the fix and the tests myself.

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/net

[github-actions]

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

• the guide for first-time contributors
• the contribution and automation policies
• the pull request guide
• the AI use policy
• the Code of Conduct

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

[par333k]

const currentSocket = this[kSocket]

The socket reference is captured when uncork() runs, so it is null if the message had no socket yet and the write was buffered in outputData. Re-reading this[kSocket] in the callback checks the socket the data was actually flushed to. In practice _flush() usually clears kNeedDrain before this callback runs, so this is a defensive guard rather than a fix for an observed crash.

[par333k]

Suggested change

	// Re-check once the flushed data has been written.
	if (!err && this.writableNeedDrain && !socket.destroyed &&
	this.writableLength === 0) {
	const currentSocket = this[kSocket];
	if (!err && this.writableNeedDrain && currentSocket &&
	!currentSocket.destroyed && this.writableLength === 0) {

[pimterry]

+1, I think without this there is likely a reachable crash here, good catch @par333k

[junyup0503]

Thanks for the suggestion! @par333k
Applied in 96a0377. The regression test and five related HTTP tests all pass.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (1c90519) to head (96a0377).
⚠️ Report is 223 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #66782      +/-   ##
==========================================
+ Coverage   90.49%   90.67%   +0.17%     
==========================================
  Files         797      797              
  Lines      277598   278783    +1185     
  Branches    53336    53611     +275     
==========================================
+ Hits       251220   252779    +1559     
+ Misses      16790    16359     -431     
- Partials     9588     9645      +57     

Files with missing lines	Coverage Δ
lib/internal/http/outgoing.js	97.99% <100.00%> (+0.01%)	⬆️

... and 121 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pimterry]

The comment here needs resolving, but otherwise I think this is good to go and fixes a real regression. Thanks for the fix @junyup0503!

[pimterry]

+1, I think without this there is likely a reachable crash here, good catch @par333k

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/78747/

[junyup0503]

I applied @par333k’s suggestion locally but missed the co-author attribution. Could we include them as a co-author in the final commit when landing this PR?