Repository navigation
vfs: validate directory renames in ZipProvider - #66976
Open
alanprado1 wants to merge 2 commits into
Open
alanprado1 wants to merge 2 commits into
alanprado1 wants to merge 2 commits into
Conversation
ZipProvider.rename() and renameSync() never inspected the destination when renaming a directory, so a directory could be merged into a non-empty directory (silently overwriting its files) or placed beneath an existing regular file. Reject both cases with ENOTEMPTY and ENOTDIR, matching rename(2) and the default provider. Directory renames also interleaved reading and writing members, so a member that failed to read (e.g. a CRC mismatch) left the members before it already written to the archive, which a writable ZipFile persists to disk. Read every member before writing any. Fixes: nodejs#66972
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZipProvider.rename()/renameSync()never inspected the destination when renaming a directory, so:ENOTEMPTY);ENOTDIR);ZipFilepersists to disk.This adds a destination check for directory renames (
ENOTDIR/ENOTEMPTY, matching rename(2) and the default provider's behaviour intest-vfs-rename.js) and reads every member before writing any.test-vfs-rename.jsalready asserts both errors, but only against the default provider, which is why this wasn't caught. The newtest-vfs-zip-provider-rename.jscovers all cases through both the sync and promise APIs, overZipBufferand a reopened writableZipFile.Not covered: a write failure partway through (e.g. an I/O error) can still leave a partial rename; that would need rollback and is left for a follow-up.
Thanks to @aron-intframe for the root-cause analysis in the issue.
Fixes: #66972