Skip to content

test: fix zipinfo non-ascii check in test-zlib-zip-interop #66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ravi-arnan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: fix zipinfo non-ascii check in test-zlib-zip-interop #66978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions test/parallel/test-zlib-zip-interop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,19 @@ test('an archive written by createZipArchive is readable by unzip, zipinfo, and

const zipinfo = spawnSync('zipinfo', [archivePath], { env });
assert.strictEqual(zipinfo.status, 0);
const zipinfoOut = zipinfo.stdout.toString();
for (const name of Object.keys(files)) {
if (!zipinfoUnicode && /[^\x20-\x7e]/.test(name)) continue;
assert.ok(zipinfo.stdout.toString().includes(name), `zipinfo missing ${name}`);
if (zipinfoOut.includes(name)) continue;
// Info-ZIP's zipinfo replaces non-ASCII bytes with '?' unless built with
// wide-character support (e.g. natspec or alt-iconv-utf8-print); stock
// builds replace non-ASCII bytes with '?' regardless of UNICODE_SUPPORT,
// which can leave replacement characters (U+FFFD) once decoded.
if (/[^\x20-\x7e]/.test(name)) {
if (!zipinfoUnicode) continue;
const placeholder = name.replace(/[^\x20-\x7e]+/g, '?');
if (zipinfoOut.replace(/[?\uFFFD]+/g, '?').includes(placeholder)) continue;
}
assert.fail(`zipinfo missing ${name}`);
}

const extractDir = path.join(dir, 'out');
Expand Down