Repository navigation
Conversation
Send to localhostIPv4 instead of 0.0.0.0. Add strict null equality assert on socket send callback error for failing fast in such cases. Fixes: nodejs#60050 Signed-off-by: gegham1 <[email protected]>
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send to localhostIPv4 instead of 0.0.0.0.
Add strict null equality assert on socket send callback error for failing fast in such cases.
Fixes: #60050
Context:
Starting from macOS Sequoia 15.0 (not 100% sure about the exact version, no official change log) when you send a UDP (or TCP) to 0.0.0.0 you get
EHOSTUNREACHerror. In this case we don't bind the port and host to the worker socket (we callsocket.bind(0)) and that causes the worker udp socket to listen on0.0.0.0:{random port}, and on linesocket.send(buf, 0, buf.length, address.port, address.address, afterSend);we just send the request to0.0.0.0thus making workers to stuck.Another fix would be passing the host in worker's
socket.bind(0)call.