Skip to content

test: convert .forEach to for...of in test-net-write-arguments.js - #67125

Open
EmmanuelFlorencioT wants to merge 1 commit into
nodejs:mainfrom
EmmanuelFlorencioT:my-first-contribution
Open

EmmanuelFlorencioT wants to merge 1 commit into
nodejs:mainfrom
EmmanuelFlorencioT:my-first-contribution

Conversation

@EmmanuelFlorencioT

Copy link
Copy Markdown

Convert .forEach to for...of in test/parallel/test-net-write-arguments.js

for...of provides a cleaner stack tests fail and avoids allocating a callback per iteration. It also prevents issues with previous unclosed colons having a conflict with the opening [

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@Ethan-Arrowood Ethan-Arrowood added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 29, 2026

@Ethan-Arrowood Ethan-Arrowood left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖 🌮

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (ee982db) to head (b92344b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67125      +/-   ##
==========================================
- Coverage   90.67%   90.66%   -0.02%     
==========================================
  Files         797      797              
  Lines      278791   278791              
  Branches    53616    53605      -11     
==========================================
- Hits       252807   252758      -49     
- Misses      16334    16391      +57     
+ Partials     9650     9642       -8     

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants