Skip to content

test: convert for each to for of in test/parallel/test-net-server-close - #67127

Open
11rls11 wants to merge 1 commit into
nodejs:mainfrom
11rls11:for-each-to-for-of-in-test-net-server-close
Open

11rls11 wants to merge 1 commit into
nodejs:mainfrom
11rls11:for-each-to-for-of-in-test-net-server-close

Conversation

@11rls11

@11rls11 11rls11 commented Oct 29, 2026

Copy link
Copy Markdown

Convert forEach() to for...of in test/parallel/test-net-server-close.js

Core style prefers for...of over .forEach() since it gives cleaner stack traces when a test fails, it works with await, and it avoids allocating a callback per iteration.

Verified with:

python3 tools/test.py test/parallel/test-net-server-close.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@Ethan-Arrowood Ethan-Arrowood added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 29, 2026

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛷️ 🧗

@11rls11
11rls11 force-pushed the for-each-to-for-of-in-test-net-server-close branch from 1ce28ac to 50d6c5f Compare October 29, 2026 23:12
@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (ee982db) to head (50d6c5f).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67127      +/-   ##
==========================================
- Coverage   90.67%   90.67%   -0.01%     
==========================================
  Files         797      797              
  Lines      278791   278791              
  Branches    53616    53617       +1     
==========================================
- Hits       252807   252782      -25     
- Misses      16334    16375      +41     
+ Partials     9650     9634      -16     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue PRs queued for automated landing through the Commit Queue. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants