Repository navigation
test: enable WPT fetch idlharness - #67129
antonioduran wants to merge 1 commit into
Conversation
Signed-off-by: Antonio Duran <[email protected]>
|
Review requested:
|
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
|
Good work on this Antonio! I think this should actually be implemented over in nodejs/undici which is the module responsible for Node.js' I don't believe Node.js' contains any web platform tests for any parts of the Fetch API; everything lives in undici instead. Let me know if you have any additional question! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67129 +/- ##
==========================================
+ Coverage 90.65% 90.66% +0.01%
==========================================
Files 797 797
Lines 278783 278791 +8
Branches 53618 53613 -5
==========================================
+ Hits 252718 252773 +55
+ Misses 16420 16369 -51
- Partials 9645 9649 +4 🚀 New features to boost your workflow:
|
Enable the Web Platform Tests fetch idlharness suite in
test/wpt/test-fetch.js.Headers,Request, andResponsealready use the Web IDL property descriptors (writable, non-enumerable, configurable), and those checks pass.fetchLater()andFetchLaterResultare recorded as expected failures because Node does not implement them. In a worker,fetchis an own property of the global object rather than ofWorkerGlobalScope.prototype, so that check is an expected failure too.