Skip to content

test: enable WPT fetch idlharness - #67129

Open
antonioduran wants to merge 1 commit into
nodejs:mainfrom
antonioduran:test-wpt-fetch-idlharness
Open

antonioduran wants to merge 1 commit into
nodejs:mainfrom
antonioduran:test-wpt-fetch-idlharness

Conversation

@antonioduran

Copy link
Copy Markdown

Enable the Web Platform Tests fetch idlharness suite in test/wpt/test-fetch.js.

Headers, Request, and Response already use the Web IDL property descriptors (writable, non-enumerable, configurable), and those checks pass. fetchLater() and FetchLaterResult are recorded as expected failures because Node does not implement them. In a worker, fetch is an own property of the global object rather than of WorkerGlobalScope.prototype, so that check is an expected failure too.

python3 tools/test.py wpt/test-fetch

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@Ethan-Arrowood Ethan-Arrowood added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 30, 2026
@Ethan-Arrowood

Copy link
Copy Markdown
Contributor

Good work on this Antonio!

I think this should actually be implemented over in nodejs/undici which is the module responsible for Node.js'fetch (and Headers, Request, Response, etc.) implementation.

I don't believe Node.js' contains any web platform tests for any parts of the Fetch API; everything lives in undici instead.

Let me know if you have any additional question!

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (510d84c) to head (a745af9).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67129      +/-   ##
==========================================
+ Coverage   90.65%   90.66%   +0.01%     
==========================================
  Files         797      797              
  Lines      278783   278791       +8     
  Branches    53618    53613       -5     
==========================================
+ Hits       252718   252773      +55     
+ Misses      16420    16369      -51     
- Partials     9645     9649       +4     

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants