Repository navigation
build: only set V8_EMBEDDER_STRING where needed - #67147
Closed
richardlau wants to merge 1 commit into
Closed
richardlau wants to merge 1 commit into
richardlau wants to merge 1 commit into
Conversation
Passing `V8_EMBEDDER_STRING` on the command line to every compilation unit invalidates the ccache for those sources when `v8_embedder_string` is bumped in `common.gypi` meaning that almost all of `deps/v8` has to be rebuilt. Only set the macro where it is needed so that embedder string bumps have minimal affects on ccache reuse. Signed-off-by: Richard Lau <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
|
I'm concerned that this requires us maintaining the list of V8 sources that use Digging a bit, I think with ccache's default settings, changing a So I'd doubt if this is beneficial. |
Member
Author
|
Fair enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
V8_EMBEDDER_STRINGon the command line to every compilation unit invalidates the ccache for those sources whenv8_embedder_stringis bumped incommon.gypimeaning that almost all ofdeps/v8has to be rebuilt.Only set the macro where it is needed so that embedder string bumps have minimal affects on ccache reuse.
cc @nodejs/v8-update
Idea for this came from discussions with @sxa around build times in the CI. This is theoretical -- I have not verified this actually speeds up builds for V8 cherry-picks (when we bump the embedder string) as it would involve timing several builds (one build without/populating the ccache, bump v8_embedder_string and then rebuild) both with and without this PR.