Skip to content

chore: set pnpm to download on fail - #9245

Merged
ovflowd merged 1 commit into
mainfrom
MattIPv4/pnpm-devengines-download
Oct 31, 2026
Merged

ovflowd merged 1 commit into
mainfrom
MattIPv4/pnpm-devengines-download

Conversation

@MattIPv4

Copy link
Copy Markdown
Member

Description

I have pnpm installed through their recommended installation method as a global binary, which is designed to manage/switch versions itself. However, with this repo, the current setup causes it to just bail out due to error being set:

pnpm -v
Error: ERR_PNPM_BAD_PM_VERSION

  × This project is configured to use 12.8.1 of pnpm. Your current pnpm is v12.14.0
  help: If you want to bypass this version check, you can set the "pmOnFail" configuration to "warn" or "ignore" (e.g. via --pm-on-fail=ignore). If using "devEngines.packageManager", you can
        set its "onFail" to "warn" or "ignore"

Instead, we can set it download, allowing pnpm to manage its own versions and download/switch to the correct version:

pnpm -v
12.8.1

Validation

pnpm continues to work locally for folks.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI balanced review requested due to automatic review settings October 29, 2026 20:02
@MattIPv4
MattIPv4 requested a review from a team as a code owner October 29, 2026 20:02
@vercel

vercel Bot commented Oct 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Oct 29, 2026 8:02pm UTC

Request Review

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (b86c448) to head (0605898).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9245      +/-   ##
==========================================
- Coverage   86.14%   86.12%   -0.02%     
==========================================
  Files          87       87              
  Lines        6149     6149              
  Branches      369      369              
==========================================
- Hits         5297     5296       -1     
- Misses        848      849       +1     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change enabling automatic downloads of the pinned pnpm version has no active review issues.

No open issues 🎉

What changed in this PR

Updates the repository’s pnpm configuration so version mismatches trigger downloading and switching to the pinned version rather than stopping with an error.

Changes:

  • Changes devEngines.packageManager.onFail from error to download, keeping pnpm pinned to 12.8.1.
File Description
package.json Enables automatic pnpm version downloading on mismatch.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.21 MB
New Total First Load JS 7.21 MB
Delta 0 B (0.00%)

@araujogui araujogui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like PNPM can also manage Node.js versions: https://pnpm.io/cli/runtime

@MattIPv4

Copy link
Copy Markdown
Member Author

It looks like PNPM can also manage Node.js versions: https://pnpm.io/cli/runtime

Yah, that's not something I use, and I don't think needs any changes in this PR? I don't want to have anything tooling-opinionated where possible; really, would rather have things done in a way where folks can use whatever tooling they desire.

@ovflowd
ovflowd added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 6dd47e4 Oct 31, 2026
18 checks passed
@ovflowd
ovflowd deleted the MattIPv4/pnpm-devengines-download branch October 31, 2026 22:38

This branch was successfully deployed

1 active deployment
Preview — 06058980 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants