Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9257 +/- ##
==========================================
- Coverage 86.91% 86.89% -0.02%
==========================================
Files 88 88
Lines 6334 6335 +1
Branches 381 380 -1
==========================================
Hits 5505 5505
- Misses 825 826 +1
Partials 4 4 ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues requiring resolution.
No open issues 🎉
What changed in this PR
Preserves download-page selections when switching between release statuses on different routes, while retaining the initial route-normalization redirect.
Changes:
- Updates the selected version in place and replaces the URL without navigating or adding a history entry.
- Exports
getPathnameto construct localized URLs. - Updates version-switching tests and adds regression coverage for preserving ARM64 across route changes.
| File | Description |
|---|---|
apps/site/navigation.mjs |
Exports the localized pathname helper. |
apps/site/components/Downloads/Release/VersionDropdown.tsx |
Replaces route-changing navigation with version and URL updates. |
apps/site/components/Downloads/Release/__tests__/VersionDropdown.test.jsx |
Checks version updates and URL replacement instead of redirects. |
apps/site/components/Downloads/Release/__tests__/PlatformDropdown.test.jsx |
Adds coverage for platform defaults and selection preservation. |
Review effort: Balanced
ovflowd
force-pushed
the
fix/download-keep-selection-on-version-change
branch
from
October 31, 2026 23:14
8bedc58 to
2953916
Compare
Contributor
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
ovflowd
force-pushed
the
fix/download-keep-selection-on-version-change
branch
from
October 31, 2026 23:28
2953916 to
dd8bf39
Compare
The route of each release status is now a STATUS_ROUTE_MAP next to STATUS_KIND_MAP, instead of string checks on the pathname (includes, endsWith and a status list). A single getRouteChange helper returns the route to move to, or nothing when already on it, and is shared by the redirect on load and the version change handler. There is no behaviour change, except that the pathname is now compared exactly. Assisted-by: Claude Sonnet 5.5 <[email protected]>
ovflowd
changed the title
ovflowd
force-pushed
the
fix/download-keep-selection-on-version-change
branch
from
October 31, 2026 23:35
dd8bf39 to
d05b99c
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies how the version dropdown decides which download route a release belongs to.
The route for each release status is now a
STATUS_ROUTE_MAPnext toSTATUS_KIND_MAP, replacing the string checks on the pathname (includes('current'),endsWith('/download'),['LTS', 'EOL'].includes(...)). A singlegetRouteChangehelper returns the route to move to, or nothing if we are already on it, and it is used by both the redirect on load and the version change handler.There is no behaviour change. The one nuance is that the pathname is now compared exactly instead of with
includes/endsWith.Validation
The existing
VersionDropdowntests are unchanged and pass: every status is checked for the redirect on load and for switching to every other status.Related Issues
Refs: #9232, #9247
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.