Skip to content

server detail path and last update format - #1301

Open
dockfries wants to merge 3 commits into
openmultiplayer:masterfrom
dockfries:master
Open

dockfries wants to merge 3 commits into
openmultiplayer:masterfrom
dockfries:master

Conversation

@dockfries

@dockfries dockfries commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Docusaurus doesn’t support dynamic routing well. It first returns a 404, then re-renders the component.

So if you visit a server details page from another locale — whether by opening the URL directly in a new tab instead or by switching the locale while already on that page — it will fallback to the default English loacle, and 404 page and then render the server details.

  • Switch server detail pages from /servers/<ip> to /servers?ip=<ip>, and legacy links are forwarded to the new URL.
  • When a server details page is accessed from the partners entry, the back button should return to the partners page
  • The last-updated label now uses locale-aware formatting via Intl.NumberFormat and refreshes every minute.
  • Unknown servers show a not-found message instead of loading indefinitely.
  • Visiting a non-existent path under any locale should not fall back to the default English 404 either — it should serve the localized 404 page for the current locale instead.
  • Add some explanations about locale options in the README.md

@dockfries dockfries changed the title server detail path, last update format, download page styles server detail path and last update format Oct 26, 2026
@dockfries
dockfries marked this pull request as ready for review October 26, 2026 18:16
@dockfries
dockfries requested review from a team, itsneufox and ulasbayraktar as code owners October 26, 2026 18:16
/servers?ip=<ip> keeps the served document pre-rendered, so the client tree matches the server HTML; legacy /servers/<ip> links are forwarded there.

The last-updated label is built from Intl.NumberFormat units in the page locale, so it fits each language's existing sentence template, and it is computed after mount and refreshed every minute.

Unknown servers now report a not-found message instead of loading forever.
@dockfries
dockfries force-pushed the master branch 2 times, most recently from b8a0046 to af02914 Compare October 27, 2026 02:10
carry the origin of the click as a from query parameter, and use it for the back link label and target.
@dockfries
dockfries force-pushed the master branch 2 times, most recently from 008aedb to 6a41f7c Compare October 27, 2026 02:56
adds locale examples for the dev server and build commands, a section on previewing a build, and switches the deploy examples from yarn to npm.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant