Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-charts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@patternfly/react-styles": "workspace:^",
"@patternfly/react-tokens": "workspace:^",
"hoist-non-react-statics": "^3.3.2",
"lodash": "^4.17.23",
"lodash": "^4.18.1",
"tslib": "^2.8.1"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-integration/demo-app-ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"@patternfly/react-core": "workspace:^",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-router": "^7.12.0",
"react-router-dom": "^7.12.0"
"react-router": "^7.14.1",
"react-router-dom": "^7.14.1"
},
"devDependencies": {
"@vitejs/plugin-react-swc": "^3.11.0",
Expand Down
8 changes: 4 additions & 4 deletions packages/react-integration/demo-app-ts/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ class App extends Component<{}, AppState> {
const htmlElement = document.getElementsByTagName('html')[0];
if (htmlElement) {
if (isDarkTheme) {
htmlElement.classList.add('pf-theme-dark');
htmlElement.classList.add('pf-v6-theme-dark');
} else {
htmlElement.classList.remove('pf-theme-dark');
htmlElement.classList.remove('pf-v6-theme-dark');

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark switching was broken

}
}
};
Expand Down Expand Up @@ -99,7 +99,7 @@ class App extends Component<{}, AppState> {
id="light-theme"
aria-label="Light theme"
label={`Light theme`}
name="light-theme"
name="theme"
isChecked={!isDarkTheme}
onChange={(_event: React.FormEvent<HTMLInputElement>, checked: boolean) =>
checked && this.onThemeSelect(false)
Expand All @@ -111,7 +111,7 @@ class App extends Component<{}, AppState> {
id="dark-theme"
label="Dark theme"
aria-label="Dark theme"
name="dark-theme"
name="theme"
isChecked={isDarkTheme}
onChange={(_event: React.FormEvent<HTMLInputElement>, checked: boolean) =>
checked && this.onThemeSelect(true)
Expand Down
2 changes: 1 addition & 1 deletion packages/react-integration/demo-app-ts/src/Demos.ts
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export const Demos: DemoInterface[] = [
},
{
id: 'modal-deprecated-demo',
name: 'Modal Demo',
name: 'Modal Deprecated Demo',
componentType: Examples.ModalDeprecatedDemo
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export const ChipDemo: React.FunctionComponent = () => (
<Chip tooltipPosition="bottom" id="longName-chip">
Chip with a really, really, REALLY long text
</Chip>
;
</>
);
ChipDemo.displayName = 'ChipDemo';
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class ClipboardCopyDemo extends Component {
isBlock
additionalActions={
<ClipboardCopyAction>
<Button variant="plain" aria-label="Run in web terminal" icon={<RhUiPlayFillIcon />} />
<Button variant="plain" hasNoPadding aria-label="Run in web terminal" icon={<RhUiPlayFillIcon />} />

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was misaligned

</ClipboardCopyAction>
}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class DrawerResizeDemo extends Component<DrawerProps, DrawerResizeDemoSta
<Button id="toggleButton" onClick={this.onClick}>
Toggle Drawer
</Button>
<Drawer isExpanded={isExpanded} onExpand={this.onExpand} position="bottom">
<Drawer isExpanded={isExpanded} onExpand={this.onExpand} position="bottom" style={{ height: '300px' }}>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not resizing.

<DrawerSection>drawer-section</DrawerSection>
<DrawerContent panelContent={panelContent}>
<DrawerContentBody>{drawerContent}</DrawerContentBody>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class MenuDrilldownDemo extends Component {
};
setHeight = (menuId: string, height: number) => {
if (
!this.state.menuHeights[menuId] ||
this.state.menuHeights[menuId] === undefined ||

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo was completely broken due to runtime error.

(menuId !== 'drilldown-rootMenu' && this.state.menuHeights[menuId] !== height)
) {
this.setState({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class NavDemo extends Component {
<Title headingLevel="h2" size="2xl">
Default Nav
</Title>
<div className="example" style={{ backgroundColor: '#212427', border: '1px solid rgb(114, 118, 123)' }}>
<div className="example">
<Nav onSelect={this.onDefaultSelect} id="nav-primary-default">
<NavList>
<NavItem id="default-link1" to="#default-link1" itemId={0} isActive={defaultActiveItem === 0}>
Expand Down Expand Up @@ -130,7 +130,7 @@ export class NavDemo extends Component {
<Title headingLevel="h2" size="2xl">
Expandable Nav
</Title>
<div className="example" style={{ backgroundColor: '#212427', border: '1px solid rgb(114, 118, 123)' }}>
<div className="example">
<Nav onSelect={this.onExpandableSelect} id="nav-primary-expandable">
<NavList>
<NavExpandable
Expand Down Expand Up @@ -253,7 +253,7 @@ export class NavDemo extends Component {
<Title headingLevel="h2" size="2xl">
Horizontal Nav
</Title>
<div style={{ backgroundColor: '#292e34', padding: '1rem' }}>
<div>
<Nav onSelect={this.onHorizontalSelect} id="nav-primary-horizontal" variant="horizontal">
<NavList>
<NavItem id="horizontal-link1" preventDefault itemId={0} isActive={horizontalActiveItem === 0}>
Expand All @@ -279,7 +279,7 @@ export class NavDemo extends Component {
<Title headingLevel="h2" size="2xl">
Horizontal Nav
</Title>
<div style={{ backgroundColor: '#292e34', padding: '1rem' }}>
<div>
<Nav onSelect={this.onHorizontalSelect} id="subnav-horizontal" variant="horizontal-subnav">
<NavList>
<NavItem id="horizontal-link1" preventDefault itemId={0} isActive={horizontalActiveItem === 0}>
Expand Down Expand Up @@ -329,9 +329,6 @@ export class NavDemo extends Component {
<div
id="flyout-nav"
style={{
backgroundColor: '#212427',
border: '1px solid rgb(114, 118, 123)',
padding: '1rem',
width: '300px'
}}
>
Expand Down
31 changes: 12 additions & 19 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5087,7 +5087,7 @@ __metadata:
fs-extra: "npm:^11.3.3"
hoist-non-react-statics: "npm:^3.3.2"
jest-canvas-mock: "npm:^2.5.2"
lodash: "npm:^4.17.23"
lodash: "npm:^4.18.1"
tslib: "npm:^2.8.1"
peerDependencies:
echarts: ^5.6.0 || ^6.0.0
Expand Down Expand Up @@ -10811,8 +10811,8 @@ __metadata:
"@vitejs/plugin-react-swc": "npm:^3.11.0"
react: "npm:^18.3.1"
react-dom: "npm:^18.3.1"
react-router: "npm:^7.12.0"
react-router-dom: "npm:^7.12.0"
react-router: "npm:^7.14.1"
react-router-dom: "npm:^7.14.1"
vite: "npm:^6.2.2"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -16702,13 +16702,6 @@ __metadata:
languageName: node
linkType: hard

"lodash@npm:^4.17.23":
version: 4.17.23
resolution: "lodash@npm:4.17.23"
checksum: 10c0/1264a90469f5bb95d4739c43eb6277d15b6d9e186df4ac68c3620443160fc669e2f14c11e7d8b2ccf078b81d06147c01a8ccced9aab9f9f63d50dcf8cace6bf6
languageName: node
linkType: hard

"lodash@npm:^4.18.1":
version: 4.18.1
resolution: "lodash@npm:4.18.1"
Expand Down Expand Up @@ -19941,21 +19934,21 @@ __metadata:
languageName: node
linkType: hard

"react-router-dom@npm:^7.12.0":
version: 7.13.0
resolution: "react-router-dom@npm:7.13.0"
"react-router-dom@npm:^7.14.1":
version: 7.18.5
resolution: "react-router-dom@npm:7.18.5"
dependencies:
react-router: "npm:7.13.0"
react-router: "npm:7.18.5"
peerDependencies:
react: ">=18"
react-dom: ">=18"
checksum: 10c0/759bd5e7fe7b5baba50a0264724188707682d217cad8eac702a55e0b1abebf295be014dd3bfaff8e3c2def9dfaa23e6ded3f908feab84df766e9b82cc3774e98
checksum: 10c0/9e19ccb3fa061d86ad90eb906657cab6b2e4313b4eb02882f7515493c3d61c978a383ee0954854f2a9238ac013bdd03c526a5de14819c8ecaae62b5280774030
languageName: node
linkType: hard

"react-router@npm:7.13.0, react-router@npm:^7.12.0":
version: 7.13.0
resolution: "react-router@npm:7.13.0"
"react-router@npm:7.18.5, react-router@npm:^7.14.1":
version: 7.18.5
resolution: "react-router@npm:7.18.5"
dependencies:
cookie: "npm:^1.0.1"
set-cookie-parser: "npm:^2.6.0"
Expand All @@ -19965,7 +19958,7 @@ __metadata:
peerDependenciesMeta:
react-dom:
optional: true
checksum: 10c0/397cb009bc83d071269c8f9323bbfe1f856721fde75e39b29fe0ddfe7564ebdc3b8bbb85768321cae92ec28b406e8fac7eab7e232d0738b3b1c092e2764e4307
checksum: 10c0/dbed9b4d0019873615028e2fe7bf7782ab4f41d9f287595b9a82f4a6d619dc5d3b88449fb3e717282f9f558312f29f88325372a7bb67355472703291607f9280
languageName: node
linkType: hard

Expand Down
Loading