Skip to content

ci: check both Go modules with govulncheck - #2729

Merged
dunglas merged 1 commit into
php:mainfrom
opctim:feature/ci-govulncheck
Oct 26, 2026
Merged

dunglas merged 1 commit into
php:mainfrom
opctim:feature/ci-govulncheck

Conversation

@opctim

@opctim opctim commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Add a standalone GitHub Actions workflow that runs govulncheck ./... for both the root and Caddy Go modules.

  • Reuse the existing Go, PHP and watcher setup and CI build tags.
  • Run on pull requests, pushes to main, daily and on manual dispatch.
  • Keep the change limited to the workflow, with no helper scripts, documentation or Dependabot changes.

Validation: actionlint, YAML and shell syntax checks passed. The actual scan still needs to run in GitHub Actions.

@dunglas CC

@dunglas
dunglas force-pushed the feature/ci-govulncheck branch from b053999 to cb75554 Compare October 26, 2026 09:19
dunglas added a commit that referenced this pull request Oct 26, 2026
`setup-go` read `go 1.27.0` from `go.mod` as an exact version, so
`check-latest` never applied. Windows, macOS and `release.yaml` builds
have been using Go 1.27.0, and the v1.13.3 Windows and macOS binaries
are affected by [GO-2026-6617](https://pkg.go.dev/vuln/GO-2026-6617)
(HTTP/2 server crash from an HPACK encoder race, fixed in Go 1.27.2).
Docker images and Linux static binaries already used the latest patch
release.

- `go.mod` and `caddy/go.mod` now declare `go 1.27`, so
`go-version-file` gives `setup-go` the minor version and `check-latest`
resolves the latest 1.27.x on every run. `go mod tidy` keeps this form.
- Lint fails on a patch release in a `go` directive or on any
`toolchain` directive. Both pin CI to a release that goes stale, `go
get` adds them back on its own, and Dependabot doesn't update them
([dependabot/dependabot-core#9527](dependabot/dependabot-core#9527)).

Unblocks #2729, which flags
GO-2026-6617 while CI runs Go 1.27.0.
@dunglas
dunglas force-pushed the feature/ci-govulncheck branch from cb75554 to 25c1131 Compare October 26, 2026 09:42
@dunglas
dunglas merged commit 2a91cf2 into php:main Oct 26, 2026
28 checks passed
@dunglas

dunglas commented Oct 26, 2026

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants