Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares required status checks on
main.Tests passedandSanitizers passedaggregate their workflow's jobs. Skipped jobs count as passing, failed or cancelled ones fail the gate.paths-ignore, so a required check would stay pending forever. ADetect changesjob now skips the jobs instead, and the gate still reports.continue-on-error, so php-src master breakage doesn't block merges.Windows build:buildalso exists in the Docker workflow, where it is skipped on PRs and could satisfy a required check.Once merged, the ruleset can require
Lint Code Base,Tests passed,Sanitizers passedandWindows build.