Repository navigation
ext/zip: Exclude broken libzip 1.12(.0) - #24358
Conversation
|
LGTM, Do we need this for 8.3 and 8.2 as well? |
|
I dont think we have that feature in 8.2. So if we are going to backport to security-only branches this should target 8.3. Oh I just realised this will not fix CI instantly, we need to wait for homebrew's image to update itself. Okay than we don't need to rush anyways. Let's wait for 8.3 RM's opinion. |
f3cf3fc to
fc7847c
Compare
|
the fix is nih-at/libzip@e3f6db9 but better to beware this version sadly no way for 8.2/8.3 |
LamentXU123
changed the title
|
Looks good to me. Does the Windows build config also need such a check? |
Well, seems like the former excluded version ain't added in Windows build condig either! Thank you for reminding. Yes. And I will also file a PR to add 1.3.1 and 1.7.0 as excluded version in Windows. |
|
I like that libzip fixed their regression, but this doesn't feel like it warrants being bundled into a |
fc7847c to
34d8e47
Compare
|
Go ahead with merging into 8.4 |
* PHP-8.6: Merge branch 'PHP-8.5' into PHP-8.6 Merge branch 'PHP-8.4' into PHP-8.5 ext/zip: Exclude broken libzip 1.12 (#24358)
* PHP-8.4: ext/zip: Exclude broken libzip 1.12 (php#24358)
* PHP-8.5: Merge branch 'PHP-8.4' into PHP-8.5 ext/zip: Exclude broken libzip 1.12 (php#24358)
libzip 1.12 introduced a regression that prevents adding or replacing files in TorrentZip archives, causing oo_torrentzip.phpt to fail. This was fixed in libzip 1.12.1.
Exclude both 1.12 and 1.12.0 at configure time, as pkg-config treats them as distinct versions (wtf bro).
See nih-at/libzip#617.