Repository navigation
ext/bcmath: Add missing error test cases for bcdivmod() - #24639
Open
spidervirus wants to merge 2 commits into
Open
spidervirus wants to merge 2 commits into
spidervirus wants to merge 2 commits into
Conversation
Add test for ValueError on malformed string inputs to bcdivmod(), and add bcdivmod() negative scale check to negative_scale.phpt.
jorgsowa
reviewed
Oct 24, 2026
jorgsowa
left a comment
jorgsowa
left a comment
Contributor
There was a problem hiding this comment.
Please check small nits for the PR. You can apply convention of $e::class, ': ', for whole negative_scale.phpt test case.
| echo $e->getMessage() . \PHP_EOL; | ||
| } | ||
| try { | ||
| bcdivmod('1','2',-1); |
Contributor
There was a problem hiding this comment.
Suggested change
| bcdivmod('1','2',-1); | |
| bcdivmod('1', '2', -1); |
| try { | ||
| bcdivmod('1','2',-1); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . \PHP_EOL; |
Contributor
There was a problem hiding this comment.
Suggested change
| echo $e->getMessage() . \PHP_EOL; | |
| echo $e::class, ': ', $e->getMessage() . \PHP_EOL; |
| bcsqrt(): Argument #2 ($scale) must be between 0 and 2147483647 | ||
| bccomp(): Argument #3 ($scale) must be between 0 and 2147483647 | ||
| bcscale(): Argument #1 ($scale) must be between 0 and 2147483647 | ||
|
|
| try { | ||
| bcdivmod('a', '1'); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; |
Contributor
There was a problem hiding this comment.
Suggested change
| echo $e->getMessage() . PHP_EOL; | |
| echo $e::class, ': ', $e->getMessage() . PHP_EOL; |
| try { | ||
| bcdivmod('1', 'a'); | ||
| } catch (\ValueError $e) { | ||
| echo $e->getMessage() . PHP_EOL; |
Contributor
There was a problem hiding this comment.
Suggested change
| echo $e->getMessage() . PHP_EOL; | |
| echo $e::class, ': ', $e->getMessage() . PHP_EOL; |
Girgias
reviewed
Oct 24, 2026
|
|
||
| try { | ||
| bcdivmod('a', '1'); | ||
| } catch (\ValueError $e) { |
Member
There was a problem hiding this comment.
And elsewhere.
Suggested change
| } catch (\ValueError $e) { | |
| } catch (\Throwable $e) { |
Update tests to catch \Throwable and prefix output with $e::class per review feedback.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing error test coverage for
bcdivmod():ext/bcmath/tests/bcdivmod_error.phptto verify that passing non-well-formed numeric strings throws aValueError.bcdivmod()negative scale test case toext/bcmath/tests/negative_scale.phpt.