Repository navigation
Fix GH-17733: System entropy does not take into account function order, resulting in wrong functions possibly called in different configurations - #24664
Conversation
…rder, resulting in wrong functions possibly called in different configurations This properly fixes the entropy computation to take into account function ordering and module versions. This is basically a reintroduction of the previously removed code from phpGH-5871, but a simpler version. Since this runs once every module startup, the overhead is negligible as it does not influence the request. I chose this simple approach rather than the suggestion to introduce multiple system entropies based on shm/file-cache. This PR also simplifies some other parts, since we can get rid of some workarounds.
|
Quoted text written with an LLM and checked by a human developer.
|
This properly fixes the entropy computation to take into account function ordering and module versions. This is basically a reintroduction of the previously removed code from GH-5871, but a simpler version. Since this runs once every module startup, the overhead is negligible as it does not influence the request.
I chose this simple approach rather than the suggestion to introduce multiple system entropies based on shm/file-cache.
This PR also simplifies some other parts, since we can get rid of some workarounds.