Repository navigation
Printer: new empty line in docblock without trailing space - #337
Merged
ondrejmirtes merged 1 commit intoOct 28, 2026
Merged
ondrejmirtes merged 1 commit into
ondrejmirtes merged 1 commit into
Conversation
A new empty PhpDocTextNode was printed as " * ". print() prints " *". Amp-Thread-ID: https://ampcode.com/threads/T-01a17930-0285-73c5-a957-4325c77aa1b2
ondrejmirtes
force-pushed
the
printer-empty-text-no-trailing-space
branch
from
October 28, 2026 10:32
eb586c7 to
21d6e6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
printFormatPreserving()printed a new emptyPhpDocTextNodeas*, with a space at the end of the line.print()prints*.Now the printer does not add the space after the asterisk when the new node prints as an empty string.