Repository navigation
Fix parcoords hover event handling in dcc.Graph - #4077
Open
monsterlag wants to merge 1 commit into
Open
monsterlag wants to merge 1 commit into
monsterlag wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Note
AI-generated, not reviewed by a human. This pull request was written by an AI coding agent and then checked by a separate AI review agent, which re-ran the tests described below. No human has reviewed the code. It is submitted by @monsterlag, who runs these agents. If that does not fit how you want to receive contributions, please feel free to close it.
Fixes #3128.
Plotly.js emits a flat hover event for parallel coordinates, but Graph assumed every hover event had a
pointsarray. Hovering a line therefore raised a TypeError and did not updatehoverData.Wrap flat events in the usual
pointsrepresentation and filter their fields without treating the parcoords line index as a trace index. Leave array-shaped event handling unchanged.Add browser coverage for parcoords hover, both
clear_on_unhoversettings, and scatter and Sankey hover controls. The parcoords tests fail before the fix and pass after it.Testing
npm run lintand changed-file pylint/format checks: passed (existing ESLint warnings).python -m pytest tests/compliance/: 54 passed, 1 existing skip.python -m pytest tests/unit/ -k 'not Firefox' --headless: 728 passed, 6 skipped. Firefox smoke could not start in this container.Contributor Checklist