Repository navigation
Conversation
Signed-off-by: Don Yin <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Fixes #3874. Fixes #3424.
Description of change
I reproduced #3874 by adding a vertical line after the 2D and 3D traces. I changed the subplot occupancy check to skip non-Cartesian traces, fixing the Table case too without changing empty-subplot behavior.
Demo
Testing strategy
I added regressions for lines and rectangles beside 3D/table traces, including empty target subplots; the core, autoshape and subplot tests passed.
ruff format --check .and lint on the changed files passed;ruff check .produced identical existing errors before and after.Guidelines