Repository navigation
Convert axhspan and axvspan to layout shapes - #5847
Open
robertoffmoura wants to merge 6 commits into
Open
robertoffmoura wants to merge 6 commits into
robertoffmoura wants to merge 6 commits into
Conversation
Contributor
|
Thanks for the PR! I'll review and follow up. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpl_to_plotlysilently drops reference spans.axhspanandaxvspanadd aRectanglepatch with a blended axes/data transform, which the renderer skipped with "I found a path object that I don't think is part of a bar chart. Ignoring.". The converted figure ends up with the spans missing completely.Fix: reference spans are now drawn as layout rectangle shapes:
xmin/xmax,ymin/ymax) map onto the axis domain (x domain/y domain), so they stay fixed to the axes on pan and zoomBefore: 0 shapes (spans dropped with a warning).
After: spans render as layout shapes.
Snippet to reproduce: