Skip to content

fix: keep PDF content with large document images inside tables - #107

Open
Herafia wants to merge 2 commits into
11.0/bugfixesfrom
fix/pdf-images-backtrack-limit-11
Open

Herafia wants to merge 2 commits into
11.0/bugfixesfrom
fix/pdf-images-backtrack-limit-11

Conversation

@Herafia

@Herafia Herafia commented Oct 28, 2026

Copy link
Copy Markdown

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

Implemented the fix from #106 in #11 (#102): images are replaced with placeholders before tables are split, and pcre.backtrack_limit is increased during TCPDF rendering.
Without this, a large document image in a table would cause the entire PDF description to disappear.
Added a test

@Herafia Herafia self-assigned this Oct 28, 2026
@Herafia
Herafia requested a review from Rom1-B October 28, 2026 14:09

@Rom1-B Rom1-B left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold until #106 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants