Repository navigation
port upstream pstack through 0.15.36 - #45
Conversation
Sync pstack from e73df47 through c742dd6: the statechart compiler, skill updates through 0.15.35, and the agentic Orchestrate playbook with the orch scripts removed. Version is 0.15.36. Co-authored-by: Kaitian Xie <[email protected]>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (harness proof missing). not merging yet.
checked on head bc31134:
- scope matches upstream e73df47..c742dd6 (0.15.33 → 0.15.36). version 0.15.36 in plugin.json, .devin-plugin/plugin.json, readme marker.
- no added lines mention cursor-team-kit,
.cursor/, or a cursor plugin manifest..cursor-plugin/plugin.jsoncorrectly skipped. - deslop / control-cli / control-ui untouched (byte-identical upstream, same as #44).
- orch scripts and interrogate references deleted like upstream.
- ci
Validate plugingreen.
blocking:
- the body says the
devincli wasn't run. this touches plugin content (statechart compiler, orchestrate, interrogate, arena, poteto-mode), so it needs devin harness proof in both regular mode and fusion mode:devin plugins install --local(or the wrapper pinned to the full head sha bc31134, not a symlink) +devin plugins list, showing pstack 0.15.36 and the changed skills loaded, including statechart, interrogate, and the three embedded ones (deslop, control-cli, control-ui). an installed-copy check ofskills/statechart/scriptsrunning from the installed plugin is a plus.
post the proof as a pr comment or in the body and i'll re-review. no issue linkage needed unless this fixes one.
harness proofreal devin cli on a local box (no cloud agent, no git clone). pr head
1. install / list2. install cache: tree, symlinks, cmp3. skills4. live turns (read-only, describe-only)each mode ran four turns via before each mode, from the scratch dir: the output was identical before the regular and the fusion runs ( statechart, interrogate, arena, and poteto-mode are regular:
|
caelaxie
left a comment
There was a problem hiding this comment.
pass. harness proof on bc31134 (issuecomment-6458411523): sha-pinned --local install, 576/576 cmp, 0 symlinks, pstack v0.15.36, skills listed, 4/4 live turns exit 0 in swe-2-max and fusion; ci green.
orchestrate.md matches upstream c742dd6 apart from the run_subagent / devin --cloud mapping main already had. not blocking.
synced to
c742dd6. comparede73df47..c742dd6forpstack/. that range is the whole upstream pstack history after the previous sync, andorigin/mainof cursor/plugins is that commit. version is0.15.36inplugin.json,.devin-plugin/plugin.json, and the readme marker.upstream range, oldest first:
34b1b7c(#977) statechart compiler7c7bde7(#978) bump to 0.15.33740d2c0(#982) qualified action names in property traces164ced1(#983) bump to 0.15.34519d36a(#981) wait for the reap in the statechart SIGKILL view testab1f702(#986) skill updates (poteto-mode, autopilot playbooks, interrogate, arena, ketchup-video, principle-explain-the-number, orchestrate, readme and guide) and bump to 0.15.35c742dd6(#1043) agentic Orchestrate, delete the orch scripts, bump to 0.15.36deslop,control-cli, andcontrol-uiare byte-identical ate73df47and atc742dd6(same blobs as devin-pstack #44). not recopied.verbatim, no devin edits:
skills/statechart/scripts/**replaced with the compiler, corpus, and tests. old.mjsscripts deleted.skills/statechart/references/render.mdadded.skills/poteto-mode/playbooks/autopilot-stack.mdreplaced.skills/poteto-mode/scripts/package.jsontest script dropsorch.skills/poteto-mode/scripts/orch/deleted (orch.ts,orch.test.ts,store.ts).skills/interrogate/references/deleted (the four review docs the rewrite removed).devin-only changes, per file:
plugin.jsonand.devin-plugin/plugin.json: version0.15.36. homepage and repository stay on this port.README.md: marker points atc742dd6/0.15.36. table rows for autopilot-stack, ketchup-video, interrogate, and statechart take the upstream wording with the existing/pstack:prefix.docs/guide/04-design.md,06-verify-and-ship.md,07-overnight.md: upstream wording,/pstack:prefix kept, existing Devin session wording kept.docs/guide/10-recipes-and-pitfalls.md: same, plus theautopitfall stays "spawn the role's subagents withsubagent_generalorsubagent_explore".skills/statechart/SKILL.md: upstream compiler skill.triggers: [user]./statechartis/pstack:statechart.skills/principle-explain-the-number/SKILL.md: upstream text.triggers: [user].skills/create-formal-verification-skill/SKILL.md: drops "which of those violations a change fixes"./pstack:statechartkept.skills/ketchup-video/SKILL.md: subtitled video.triggers: [user]./pstack:ketchupand/pstack:ketchup-videokept.skills/poteto-help/SKILL.mdandreferences/recipes.md: upstream rows and prompts./pstack:prefix, cloud Devin session wording, and the Devin webhook row kept.skills/arena/SKILL.md: new drop-a-seat rule and the skip-the-judge rule, in the existing profile language (~/.devin/rules/pstack-models.md,pstack-M/pstack-M-ro,subagent_general/subagent_explore,devin models list,swe-2-high).autoon the cross-judge line never judges. On Fusion, prefer a judge outside both the lead's and the sidekick's families, else outside the lead's. afusion-*slug is still a rejected slug.skills/interrogate/SKILL.md: upstream rewrite (findings survive only when a rerun proves them; it calls arena phases).triggers: [user].generalPurposeis the write profile arena phase A step 3 maps (pstack-M, orsubagent_generalforauto/inherit-parent).skills/setup-pstack/SKILL.md: the cross-judge sentence is the new one (one judge, other family, list order, alias never judges). Fusion note,ask_user_question, and Adaptive wording stay.skills/poteto-mode/SKILL.md: new first-message trigger, Explain the Number applies before you measure,is_background: truealso covers a steer or resume, and a rejected adjusted slug falls through the calling skill's fallback thendevin models list/ theautomapping. Autopilot-stack is autopilot-full without the merge. Fusion paragraphs stay.skills/poteto-mode/playbooks/autonomous-run.md: mid-run discoveries that support the goal.ask_user_questionand Devin's/loopstay.skills/poteto-mode/playbooks/autopilot-full.md: upstream rebase, verify, blocking, and reply rules. owners stay cloud Devin sessions (devin --cloud)./deslopand/pstack:no-commentsstay. control-cli and control-ui stay plain skill names.skills/poteto-mode/playbooks/babysit.md: an Autopilot-stack owner rebases its own branch the same way an Autopilot-full owner does. Origin and GitHub watcher wording stays.skills/poteto-mode/playbooks/opening-a-pr.md: the subagent runs/deslopand/pstack:no-commentsand reports merge-ready.interrogateand STACK-READY are gone.skills/poteto-mode/playbooks/multi-phase-plan.md: pick autopilot-full when the run may merge, autopilot-stack when the operator lands the PRs. verdict checklist matches upstream. explores withprofile: "pstack:poteto-agent".skills/poteto-mode/playbooks/orchestrate.md: replaced with the short agentic playbook.Taskisrun_subagent. workers are cloud Devin sessions (devin --cloud -p), leaf-level, because a cloud session cannot spawnpstack-*profiles. program state goes in the current agent's store (path in the system prompt), not a project tracker. control-cli and control-ui are named with no plugin qualifier. no orch script calls.skipped:
pstack/.cursor-plugin/plugin.json. cursor plugin manifest. the only change in range is the version bump, and this port's manifests areplugin.jsonand.devin-plugin/plugin.json..claude-pluginfile changed in the range.docs/harness/claude-code.mddid not change in the range and is not part of this port.tests:
bash -nonskills/poteto-mode/scripts/worktree-audit.shandskills/show-me-your-work/scripts/log.sh.skills/poteto-mode/scripts:bun run typecheckandbun run test(watch-pr and check-plan). 61 pass, 0 fail.skills/statechart/scripts:node --test test/*.test.tson Node v22.23.4. 267 pass, 0 fail, 67 skipped. the skips are the plain-TLC differential cases, which the suite itself skips unlessTLA2TOOLSpoints attla2tools.jar. corpus replay, the SIGKILL reap test, and the Pele render tests ran.devinCLI was not run. it needs a login. harness proof for regular mode and fusion mode stays with the owner.