Repository navigation
Remove legacy manifest publishing and package-set mirroring - #818
Open
thomashoneyman wants to merge 3 commits into
Open
thomashoneyman wants to merge 3 commits into
thomashoneyman wants to merge 3 commits into
Conversation
Require purs.json or spago.yaml for new source publications, including retries. Remove conversion code and its SemVer dependency while retaining stored package compatibility and license detection.
Remove legacy repository writes, JSON and Dhall conversion, compatibility maps, and release tags. Retain modern registry package sets and assert they publish without a legacy checkout or API requests.
Use the existing manifest codec and canonical-license check. Remove schema resources, Dhall tooling, obsolete fixtures, and unused GitHub and source-fetching paths with their dependencies. Keep version normalization in a small shared utility. Remove automatic inclusion of unsupported manifests and regenerate synthetic publication archives while preserving published fixture data.
thomashoneyman
force-pushed
the
retire-legacy-publishing
branch
from
October 23, 2026 20:11
90c227b to
ce73c96
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the core, contrib, web, node, and halogen libraries have migrated to modern Spago, we can go ahead with #744 and #745.
This is split into three commits. The first removes publishing from
bower.jsonandspago.dhall, so packages must providepurs.jsonorspago.yaml. The second stops mirroring package sets topurescript/package-sets, including the legacy JSON sets, Dhall sets, compatibility map, and release tags. The third removes the Dhall specification types and tools. We already have PureScript codecs for the registry types, so there’s no need to also run manifests through Dhall.While doing this, I also removed the unused GitHub file-content fetching code and the dependencies and tests that only existed for it.
Existing published packages and legacy package-set releases are left alone. However, publishing from an old tag containing only a legacy manifest will no longer work. That includes retries to finish an incomplete publication or upload missing documentation — those sources need a supported manifest too.
There are a few follow-ups outside this repository, tracked in #745:
purescript/package-setsworkflow that still uploads Dhall release assets when apsc-*tag is pushed. Existing releases should remain available.DHALL_TYPESsetting and update the legacy-publishing documentation inpurescript/registry. Its daily jobs are still needed.I don’t think these need to block this PR, but we should do them as part of the rollout rather than consider the deprecation finished when this merges.