Repository navigation
Return the supplied default for missing raw options - #549
Open
rupayon123 wants to merge 2 commits into
Open
rupayon123 wants to merge 2 commits into
rupayon123 wants to merge 2 commits into
Conversation
rupayon123
marked this pull request as ready for review
October 27, 2026 14:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArgvInput.parameter_option("--name", default="fallback")returnsFalsewhen no token matches. Its existing end-of-options branch already returns the supplied default.Return that default after an exhausted scan too. Tests cover empty and unrelated tokens, single/list option names,
False,0,None, string and object defaults, plus present values and--controls. The separate attached-value work in #538 is untouched.Validation on macOS arm64/CPython 3.13.14 with dependencies from
poetry.lock: 274 tests pass, three existing skips; mypy, all-file pre-commit checks, package build and built-wheel API checks pass. The inheritedNO_COLOR=1environment triggers the same existing FORCE_COLOR test failure on the pristine base; the passing full run unsets that inherited variable. Other Python/OS combinations were not run locally.Includes the required
news/549.bugfix.mdchangelog entry.