Repository navigation
Conversation
lpyu001
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
September 12, 2026 08:26
Member
|
Please update the branch, and include HWAsan. |
Contributor
Author
|
Also fix |
StanFromIreland
changed the title
|
|
||
|
|
||
| class TestSupport(unittest.TestCase): | ||
| def test_check_sanitizer_config_args(self): |
Member
There was a problem hiding this comment.
Please move this down, at least past the classmethods. Honestly, however, I think we can drop it entirely.
Comment on lines
+1
to
+3
| Honor ``=no`` and ``--without-...`` for the AddressSanitizer, | ||
| HWAddressSanitizer, MemorySanitizer, UndefinedBehaviorSanitizer, and | ||
| ThreadSanitizer configure options without adding sanitizer flags. |
Member
There was a problem hiding this comment.
Suggested change
| Honor ``=no`` and ``--without-...`` for the AddressSanitizer, | |
| HWAddressSanitizer, MemorySanitizer, UndefinedBehaviorSanitizer, and | |
| ThreadSanitizer configure options without adding sanitizer flags. | |
| Fix the :samp:`--with-{name}-sanitizer=no` and :samp:`--without-{name}-sanitizer` | |
| :program:`configure` options enabling the sanitizer instead of disabling it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor =no and --without-... for all four sanitizer options while preserving the existing behavior for other explicitly supplied values.
=novalues for sanitizer configure options still enable sanitizer flags #157354