Repository navigation
gh-159739: Keep descriptor metadata dictionaries alive during insertion - #160193
JelleZijlstra merged 1 commit into
Conversation
…nsertion The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14.
|
Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
JelleZijlstra
added
needs backport to 3.14
|
Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-160382 is a backport of this pull request to the 3.15 branch. |
…nsertion (pythonGH-160193) The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14. (cherry picked from commit a076a55ad2a318cd8b7010d85ccf21ccd0a98555) Co-authored-by: Jelle Zijlstra <[email protected]>
|
GH-160383 is a backport of this pull request to the 3.14 branch. |
|
Sorry @jelle-openai and @JelleZijlstra, I had trouble completing the backport. Please retry by removing and re-adding the "needs backport to 3.14" label. |
…nsertion (pythonGH-160193) The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14. (cherry picked from commit a076a55ad2a318cd8b7010d85ccf21ccd0a98555) Co-authored-by: Jelle Zijlstra <[email protected]>
|
Sorry @jelle-openai and @JelleZijlstra, I had trouble completing the backport. Please retry by removing and re-adding the "needs backport to 3.15" label. |
2 participants
The classmethod and staticmethod metadata setters dropped their reference to the descriptor dictionary before inserting the new value. A key comparison or value finalizer can replace the dictionary during insertion, leaving the operation using released memory. Keep the dictionary alive until insertion finishes. Backport to 3.15 and 3.14.