Repository navigation
[3.14] Clarify TLS 1.3 behavior of the SSLContext PSK callbacks (GH-160159) - #160423
Merged
Merged
Conversation
…0159) Under TLS 1.3 a PSK is only offered and may be declined, and both sides fall back to certificate authentication when one is available, so CERT_NONE leaves the server unauthenticated and a zero length PSK does not reject the connection. Drop CERT_NONE from the example and the PSK tests. A callback that raises is treated like one returning a zero length PSK, so under TLS 1.3 it also falls back to certificate authentication. A server with a certificate loaded declines even a matching PSK with OpenSSL's default TLS 1.3 cipher suite order, which selects a SHA-384 suite. Mention checking session_reused as the client side alternative to not using CERT_NONE. (cherry picked from commit 9b9657cf54060926721abff72b2aa28b7701d3c6) Co-authored-by: Gregory P. Smith <[email protected]>
bedevere-app
Bot
added
awaiting review
tests
Documentation build overview
321 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under TLS 1.3 a PSK is only offered and may be declined, and both sides
fall back to certificate authentication when one is available, so
CERT_NONE leaves the server unauthenticated and a zero length PSK does
not reject the connection. Drop CERT_NONE from the example and the PSK
tests.
A callback that raises is treated like one returning a zero length PSK,
so under TLS 1.3 it also falls back to certificate authentication. A
server with a certificate loaded declines even a matching PSK with
OpenSSL's default TLS 1.3 cipher suite order, which selects a SHA-384
suite. Mention checking session_reused as the client side alternative
to not using CERT_NONE.
(cherry picked from commit 9b9657c)
Co-authored-by: Gregory P. Smith [email protected]