Repository navigation
gh-141004: document the Python version adding each PyExpat_CAPI member - #160471
Merged
encukou merged 2 commits intoOct 23, 2026
Merged
Conversation
Documentation build overview
6 files changed ·
|
ZeroIntensity
approved these changes
Oct 23, 2026
ZeroIntensity
left a comment
ZeroIntensity
left a comment
Member
There was a problem hiding this comment.
I think this is fine, but I suspect @encukou has some stronger opinions here.
encukou
reviewed
Oct 23, 2026
Comment on lines
+26
to
+28
| && capi->MAJOR_VERSION == XML_MAJOR_VERSION | ||
| && capi->MINOR_VERSION == XML_MINOR_VERSION | ||
| && capi->MICRO_VERSION == XML_MICRO_VERSION |
Member
There was a problem hiding this comment.
This is something we weren't sure about. Is the version-checking necessary?
Does expat break ABI (even in minor versions)?
Member
Author
There was a problem hiding this comment.
As discussed: I'm going to only suggest checking the magic number and size as the version checking may even be wrong for consumers (for us it's correct but not necessarily for others).
picnixz
commented
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.