Skip to content

gh-158979: Fix textwrap hang when an indent is longer than width #160559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devdavidejesus wants to merge 1 commit into from
Closed

gh-158979: Fix textwrap hang when an indent is longer than width #160559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_textwrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,6 +760,14 @@ def test_subsequent_indent(self):
initial_indent=" * ", subsequent_indent=" ")
self.check(result, expect)

def test_indent_longer_than_width(self):
# gh-160558: wrap() looped forever when an indent was longer than
# width.
self.check_wrap(" ", 3, [], initial_indent="----")
self.check_wrap(" a", 3, ["----a"], initial_indent="----")
self.check_wrap("aaaa", 3, ["aaa", "----a", "----"],
subsequent_indent="----", drop_whitespace=False)


# Despite the similar names, DedentTestCase is *not* the inverse
# of IndentTestCase!
Expand Down
2 changes: 1 addition & 1 deletion Lib/textwrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def _wrap_chunks(self, chunks):
l = len(chunks[-1])

# Can at least squeeze this chunk onto the current line.
if cur_len + l <= width:
if cur_len + l <= width or not l:
cur_line.append(chunks.pop())
cur_len += l

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-10-24-00-53-48.gh-issue-160558.XyEOEz.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :func:`textwrap.wrap` and :func:`textwrap.fill` hanging in some cases
when *initial_indent* or *subsequent_indent* is longer than *width*.
Loading