Skip to content

gh-130662: Remove unnecessary plus sign from news entry - #160723

Merged
StanFromIreland merged 1 commit into
python:mainfrom
rffontenelle:patch-5
Oct 26, 2026
Merged

StanFromIreland merged 1 commit into
python:mainfrom
rffontenelle:patch-5

Conversation

@rffontenelle

@rffontenelle rffontenelle commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Remove leading plus sign added in #132549 from NEWS entry.

Ultimately, the leading plus sign may cause Sphinx warning if a translator doesn't write +:class:`~decimal.Decimal` like the original like:

build/NEWS:8698: WARNING: inconsistent cross-references in translated message. original: ['`~decimal.Decimal`'], translated: [':class:`~decimal.Decimal`'] [i18n.inconsistent_references]

See Brazilian Portuguese translation for instance. Notice how the original message (msgid) has a plus sign write before the class role and the translation message (msgstr) doesn't, which caused the above warning:

#: ../NEWS:8672
msgid ":gh:`130662`: +Accept leading zeros in precision and width fields for +:"class:`~decimal.Decimal` formatting, for example ``format(Decimal(1.25), '.016f')``."
msgstr ":gh:`130662`: Aceita zeros à esquerda em campos de precisão e largura para formatação :class:`~decimal.Decimal`, por exemplo ``format(Decimal(1.25), '.016f')``."

The Sphinx warning was spotted in https://translations.python.org/build-details.html, browsing the pt-br count.

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Oct 26, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Oct 26, 2026
@rffontenelle rffontenelle changed the title gh-130662: Remove unecessary plus sign from news entry gh-130662: Remove unnecessary plus sign from news entry Oct 26, 2026
@StanFromIreland
StanFromIreland merged commit 3acc941 into python:main Oct 26, 2026
48 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Oct 26, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @rffontenelle for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@StanFromIreland

Copy link
Copy Markdown
Member

Merged, thanks!

@miss-islington-app

Copy link
Copy Markdown

Sorry, @rffontenelle and @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 3acc941f2b7288b212a4163ab21aa79faff9cd13 3.14

@bedevere-app

bedevere-app Bot commented Oct 26, 2026

Copy link
Copy Markdown

GH-160729 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 26, 2026
@rffontenelle
rffontenelle deleted the patch-5 branch October 26, 2026 17:50
@bedevere-app

bedevere-app Bot commented Oct 26, 2026

Copy link
Copy Markdown

GH-160730 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 26, 2026
@StanFromIreland

Copy link
Copy Markdown
Member

Merged, thanks!

@rffontenelle

Copy link
Copy Markdown
Contributor Author

@StanFromIreland This is an entry for 3.15 alpha NEWS, so I assume it doesn't apply to 3.14 (sorry for not mentioning it before).

@StanFromIreland

Copy link
Copy Markdown
Member

It was backported to 3.14, so it does. I made a backport in #160730.

StanFromIreland pushed a commit that referenced this pull request Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants