Repository navigation
gh-160781: Only test BytesIO write overflow on the C implementation - #160903
Merged
Merged
Conversation
Member
Author
|
!buildbot x86.Debian |
|
🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit 14f8007 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F160903%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
cmaloney
approved these changes
Oct 29, 2026
cmaloney
left a comment
cmaloney
left a comment
Contributor
There was a problem hiding this comment.
thanks for fixing the bot!
StanFromIreland
added
needs backport to 3.14
|
Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-160910 is a backport of this pull request to the 3.14 branch. |
|
GH-160911 is a backport of this pull request to the 3.15 branch. |
StanFromIreland
added a commit
that referenced
this pull request
Oct 29, 2026
…ation (GH-160903) (#160910) (cherry picked from commit 8dbc313) Co-authored-by: Stan Ulbrych <[email protected]>
StanFromIreland
added a commit
that referenced
this pull request
Oct 29, 2026
…ation (GH-160903) (#160911) (cherry picked from commit 8dbc313) Co-authored-by: Stan Ulbrych <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the failures reported in #160783 (comment). The write test added we added ran against
_pyio.BytesIOtoo, and on 32-bit platforms its paddingresize()(to about 2 GiB!) can succeed before the one-byte slice assignment fails, leaving the buffer enlarged. The followinggetvalue()then raisedOverflowErrorfrombytes(self._buffer). Let's move the test intoCBytesIOTest.