Repository navigation
gh-160913: Use the dict freelist in dict() - #160922
Merged
Merged
Conversation
dict_vectorcall() allocated every instance with _PyType_AllocNoTrack(),
so dict() never reused the objects that {} and PyDict_New() recycle
through the freelist. Allocate with PyDict_New() instead. tp_vectorcall
is not inherited by subclasses, so dict_vectorcall() only ever runs for
the exact dict type; assert that rather than checking it.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
bedevere-app
Bot
added
awaiting core review
type-feature
cmaloney
approved these changes
Oct 29, 2026
Contributor
|
There's an additional direct allocation which misses the freelist in |
methane
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dict_vectorcallallocated every instance with_PyType_AllocNoTrack(), so skipping the freelist.tp_vectorcallis not inherited by subclasses, so dict_vectorcall() only ever runs for the exact dict type.dict()dict(d3)dict(pairs_3)dict(a=1, b=2)dict(d_100)x + y{}d3.copy()