Repository navigation
stubgen: keep explicit type aliases when TypeAlias comes from an unanalyzed module - #22295
Open
NavpreetSSidhu wants to merge 1 commit into
Open
NavpreetSSidhu wants to merge 1 commit into
NavpreetSSidhu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22294
When
TypeAliasis imported from a module that isn't part of the stubgen run (for example a private_typesmodule skipped without--include-private), the import can't be resolved and the annotation is analyzed asAny. Thegetattr(o.type, "name", None) == "TypeAlias"check then fails, so the assignment isn't treated as an explicit alias and its value is dropped.When
o.typeisAny, this falls back to the unanalyzed annotation's name, which is what the check sees when the import does resolve. A resolved type that merely happens to be namedTypeAliasis still not matched.Added
testExplicitTypeAliasFromUnanalyzedModule_semanal, which fails on master and passes with this change.I used Claude Code to help write this.