Repository navigation
Conversation
…tings. Also ignores values of NO_PROXY that aren't a simple 'true'. Fixes python#425
Member
Author
|
No tests yet, just wanted to get the change started. |
There was a problem hiding this comment.
🟡 Changes recommended
Credential exposure in configuration logging and incomplete proxy configuration handling block approval.
5 open issues
What changed in this PR
This PR adds configuration-backed proxy settings to PyManager and addresses the global proxy bypass reported in #425 by warning on unsupported NO_PROXY values rather than treating them as a blanket bypass.
Changes:
- Adds proxy and download credential settings with environment-variable defaults.
- Introduces explicit proxy information for download helpers and boolean-style
NO_PROXYhandling. - Updates proxy tests to pass settings directly and check bypass values and warnings.
| File | Description |
|---|---|
| tests/test_urlutils.py | Updates proxy tests and adds NO_PROXY value coverage. |
| src/pymanager.json | Adds environment-backed proxy and credential defaults. |
| src/manage/urlutils.py | Adds proxy configuration arguments and revised bypass parsing. |
| src/manage/install_command.py | Uses configured credentials and removes unused parameters. |
| src/manage/commands.py | Defines proxy and credential configuration fields. |
Review effort: Balanced
zooba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also ignores (and warns about) values of NO_PROXY that aren't a simple true/false value (1/0/yes/no/etc.).
Related to #425 but not a complete fix.